Migrate unit tests to GitHub #175
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeinaJi
force-pushed
the
weji/actions_improve
branch
from
dbf4d05
to
3136109
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
WeinaJi
force-pushed
the
weji/actions_improve
branch
from
e9a45da
to
fc109a8
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
WeinaJi
force-pushed
the
weji/actions_improve
branch
from
0fb721f
to
8650471
Compare
This comment has been minimized.
This comment has been minimized.
WeinaJi
changed the title
jorblancoa
force-pushed
the
weji/actions_improve
branch
from
8650471
to
e7421a6
Compare
jorblancoa
force-pushed
the
weji/actions_improve
branch
from
cb7d5ce
to
1e03b4b
Compare
matz-e
reviewed
Sep 23, 2024
matz-e
reviewed
Sep 30, 2024
jorblancoa
force-pushed
the
weji/actions_improve
branch
from
a1a7ebf
to
5084dee
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…apses. Install latest libsonata branch
jorblancoa
force-pushed
the
weji/actions_improve
branch
from
50eff37
to
9998205
Compare
This comment has been minimized.
This comment has been minimized.
WeinaJi
commented
Oct 2, 2024
ferdonline
reviewed
Oct 2, 2024
| @@ -14,8 +14,6 @@ def test_input_resistance(): | |||
| # create Node from config | |||
| GlobalConfig.verbosity = LogLevel.VERBOSE | |||
| n = Node(str(CONFIG_FILE)) | |||
| # use edges file w/o plasticity | |||
| SimConfig.extra_circuits["All"]["nrnPath"] = EDGES_FILE + ":default" | |||
There was a problem hiding this comment.
We don't need to restrict the population anymore?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Logfiles from GitLab pipeline #235315 (:no_entry:) have been uploaded here! Status and direct links: |
matz-e
reviewed
Oct 10, 2024
Comment on lines
+240
to
+243
| pip install flake8 flake8-pyproject | ||
|
|
||
| - name: Run flake8 | ||
| run: flake8 . |
There was a problem hiding this comment.
Can you run flake independently on the sources only with no installation? As in separate job with separate status?
Also, ruff may be a better all-in-one linter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR migrates the unit test pipeline from GitLab to GitHub actions. Based on the existing
simulation_test.yml, it adds the model building forneocortexandneocortex-mutiscalemodels, and launch the unit tests viapytest. For testing data, sub circuits ofv5_sonata,v5_sonata + gap junctions,sscx-v7-plasticityare extracted bybrainbuilderfrom the original circuits ingpfsand are stored locally.Scope
Doc builds are tested on ReadTheDocs side for all PRs.
Testing
Currently the follow tests are skipped:
Review